Skip to content

[Docs] Typo in DiscountOffer type. #249

Description

@TiPEX360

Documentation area

openiap.dev

Page or file

https://www.openiap.dev/docs/types/discount-offer

What should be changed?

Docs imply that the DiscountOffer type maps to SubscriptionOfferDetails despite supporting one-time product offers.

Contrastingly, it also points to the native-reference ProductDetails.OneTimePurchaseOfferDetails, confirming it is for a one-time purchase discount.

Furthermore, it says the type is a 'Unified discount-offer type covering both subscription discounts (Introductory, Promotional) and one-time product offers (OneTime, Android only on Google Play Billing Library 8.0+).' This seems correct for Android, but it's worth noting it's also only available on the ProductAndroid type. Perhaps this is in prepartion for one-time offers being available on iOS in the future?

What to change?

This should be cleared up to better convey what the object is really for: one-time product offers and not subscription offers.

Suggested wording or structure

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    📖 documentationImprovements or additions to documentation🛠 bugfixAll kinds of bug fixes🤖 androidRelated to android

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions