-
-
Notifications
You must be signed in to change notification settings - Fork 30
[Docs] Typo in DiscountOffer type. #249
Copy link
Copy link
Closed
Labels
📖 documentationImprovements or additions to documentationImprovements or additions to documentation🛠 bugfixAll kinds of bug fixesAll kinds of bug fixes🤖 androidRelated to androidRelated to android
Description
Activity
Metadata
Metadata
Assignees
Labels
📖 documentationImprovements or additions to documentationImprovements or additions to documentation🛠 bugfixAll kinds of bug fixesAll kinds of bug fixes🤖 androidRelated to androidRelated to android
Documentation area
openiap.dev
Page or file
https://www.openiap.dev/docs/types/discount-offer
What should be changed?
Docs imply that the
DiscountOffertype maps toSubscriptionOfferDetailsdespite supporting one-time product offers.Contrastingly, it also points to the native-reference ProductDetails.OneTimePurchaseOfferDetails, confirming it is for a one-time purchase discount.
Furthermore, it says the type is a 'Unified discount-offer type covering both subscription discounts (Introductory, Promotional) and one-time product offers (OneTime, Android only on Google Play Billing Library 8.0+).' This seems correct for Android, but it's worth noting it's also only available on the
ProductAndroidtype. Perhaps this is in prepartion for one-time offers being available on iOS in the future?What to change?
This should be cleared up to better convey what the object is really for: one-time product offers and not subscription offers.
Suggested wording or structure
No response