Android: fetchProducts({ type: 'all' }) returns [] — FetchProductsResultAll dropped in ExpoIapModule.kt

[vladyslavbaranov25]

Title

Android: fetchProducts({ type: 'all' }) returns [] — FetchProductsResultAll dropped in ExpoIapModule.kt

---

Description

Summary

On Android, fetchProducts({ skus, type: 'all' }) resolves to an empty array [], even when the exact same SKUs return correctly via fetchProducts({ skus, type: 'subs' }). So 'subs' (and 'in-app') work, but 'all' silently returns nothing.

Environment

• expo-iap: 4.3.1
• openiap-google: 2.2.1 (pinned in openiap-versions.json)
• React Native: 0.83.4, Expo SDK 55
• Platform: Android (Google Play Billing)

Reproduction

With one or more active subscriptions configured in Play Console:

// returns []  ❌
await fetchProducts({ skus: ['com.example.monthly'], type: 'all' });

// returns [{ id: 'com.example.monthly', type: 'subs', ... }]  ✅
await fetchProducts({ skus: ['com.example.monthly'], type: 'subs' });

Expected behavior

type: 'all' returns the union of in-app + subscription products (the docs state: "a mixed array for 'all'").

Actual behavior

type: 'all' → []. 'subs' and 'in-app' each work individually.

Root cause

In android/src/main/java/expo/modules/iap/ExpoIapModule.kt, the fetchProducts function maps only two of the three sealed FetchProductsResult subtypes returned by openiap-google:

val result = openIap.fetchProducts(request)
val payload = when (result) {
    is FetchProductsResultProducts      -> result.value.orEmpty().map { it.toJson() }
    is FetchProductsResultSubscriptions -> result.value.orEmpty().map { it.toJson() }
    else -> emptyList<Map<String, Any?>>()   // ← FetchProductsResultAll lands here
}

The flow is correct right up to this point:

• parseProductQueryType("all") → ProductQueryType.All (correct).
• openiap-google handles All correctly: it queries Google Play for both "inapp" and "subs" (each wrapped in its own runCatching, so an empty in-app half does not drop the subs half) and returns a populated FetchProductsResultAll (List<ProductOrSubscription>).
• expo-iap then discards it: there is no is FetchProductsResultAll branch (the type isn't even imported), so the populated result hits else -> emptyList().

'subs' works because openiap returns FetchProductsResultSubscriptions, which is matched.

This branch is still missing on main.

Proposed fix

Add the missing branch (and import dev.hyo.openiap.FetchProductsResultAll):

when (result) {
    is FetchProductsResultProducts      -> result.value.orEmpty().map { it.toJson() }
    is FetchProductsResultSubscriptions -> result.value.orEmpty().map { it.toJson() }
    is FetchProductsResultAll           -> result.value.orEmpty().map { it.toJson() }  // add
    else -> emptyList<Map<String, Any?>>()
}

Workaround

Query 'subs' and 'in-app' separately and merge the results, avoiding 'all' entirely.

[gitdogbot]

@vladyslavbaranov25

Correction: The earlier answer was wrong. It checked the core Google implementation but missed the Expo Android bridge named in the issue.

The core Android module can return FetchProductsResultAll correctly, but that does not prove expo-iap returns it correctly. For this issue the important path is the Expo bridge: libraries/expo-iap/android/src/main/java/expo/modules/iap/ExpoIapModule.kt also has to map the FetchProductsResultAll union into the JS-facing result. The bug was that the mixed all result could fall through to an empty array when the bridge only handled the product-only and subscription-only variants.

So this was a valid cross-package bridge bug, not a “not reproducible” issue. The maintainer confirmed the root cause and fixed it in #193, with related union-drift fixes across other framework wrappers.

---

🤖 Generated by gitdog.hyo.dev · Have more questions? Tag @gitdog and let me know!

[hyochan]

Root cause confirmed: Android fetchProducts(type: all) returns the FetchProductsResultAll union from the OpenIAP core, but the Expo Android bridge only mapped the products and subscriptions variants, so the mixed all variant fell through to an empty array.

While auditing the same pattern, I also found and fixed related union drift in Flutter Android, KMP Android/iOS, and the Google Horizon variant. React Native, Godot, and MAUI already handled the mixed all result correctly.

Fix is up in #193.

Note: This repository (OpenIAP monorepo) handles development for all framework libraries from the versions listed below. For earlier versions, refer to the archived individual repositories.

• react-native-iap v15.0.0+
• expo-iap v4.0.0+
• flutter_inapp_purchase v9.0.0+
• godot-iap v2.0.0+
• kmp-iap v2.0.0+