Repository navigation
feat(html): support promises directly in content expressions - #312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now a Promise could only be rendered through the
html.resolve()helper, even though in most real-world cases the pending placeholder it provides is not needed and the extra wrapper is just noise in the template.Content expressions now accept a Promise directly: the current content stays in place until the promise settles, then the resolved value is rendered by the same rules as any other content value (template, array, Node or primitive), and a stale promise is ignored when the expression is updated before it resolves. The logic lives in a new
resolvers/promise.js, withresolveValueonly mapping a promiselastValueto the actually rendered value so type-change cleanup and DOM reuse keep working. Tests, docs and thehtml.resolvetype comment are updated accordingly;html.resolve()remains available for cases that need a placeholder.