Repository navigation
fix: make @chisel_firtool resolvable when rules_chisel is a dependency - #8
Merged
Merged
Conversation
The verilog rules' implicit _firtool attribute defaults to @chisel_firtool//:bin/firtool, an apparent repo name resolved through rules_chisel's own repo mapping. That mapping entry comes from the chisel module extension, which MODULE.bazel declares with dev_dependency = True — so it exists in this repo's own (root-module) CI, but is dropped whenever rules_chisel is consumed as a dependency. Any consumer using fir_library / verilog_directory / verilog_file then fails analysis with: No repository visible as '@chisel_firtool' from repository '@@rules_chisel+' Declare the extension use as a regular dependency. Settings resolution already prefers the root module's chisel.toolchain tag, so this module's own tag only serves as the fallback default for consumers that don't configure one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
@MrAMS Makes sense? |
MrAMS
approved these changes
Aug 26, 2026
MrAMS
left a comment
MrAMS
left a comment
Member
There was a problem hiding this comment.
Yes, this makes sense to me. Thank you!
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verilog rules' implicit
_firtoolattribute defaults to@chisel_firtool//:bin/firtool, an apparent repo name resolved through rules_chisel's own repo mapping. That mapping entry comes from thechiselmodule extension, whichMODULE.bazeldeclares withdev_dependency = True— so it exists in this repo's own (root-module) CI, but is dropped whenever rules_chisel is consumed as a dependency. Any consumer usingfir_library/verilog_directory/verilog_filethen fails analysis with:Reproduce: from any module that has
bazel_dep(name = "rules_chisel", version = "0.4.1"), build afir_librarytarget.Fix: declare the extension use as a regular dependency. Settings resolution (
_collect_settings) already prefers the root module'schisel.toolchaintag, so this module's own tag only serves as the fallback default for consumers that don't configure one — which also makes the verilog rules work out of the box.🤖 Generated with Claude Code