refactor: rename SelectionBarControl.CommandParameter to Selection - #1096
Open
huynhsontung with Copilot wants to merge 2 commits into
Open
huynhsontung with Copilot wants to merge 2 commits into
huynhsontung with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: huynhsontung <31434093+huynhsontung@users.noreply.github.com>
Co-authored-by: huynhsontung <31434093+huynhsontung@users.noreply.github.com>
huynhsontung
added this pull request to stack #1097
September 16, 2026 09:22
Copilot created this pull request from a session on behalf of
huynhsontung
September 16, 2026 09:22
View session
huynhsontung
marked this pull request as ready for review
September 16, 2026 20:25
United600
reviewed
Sep 16, 2026
| x:Name="PlayButton" | ||
| Command="{x:Bind PlayButtonCommand}" | ||
| CommandParameter="{x:Bind CommandParameter}" | ||
| CommandParameter="{x:Bind Selection}" |
Collaborator
There was a problem hiding this comment.
It feels unnecessary, so we should drop it from any buttons that don't require it and keep it solely on the AddToPlaylistButton. Unless we revert the commands to require a parameter again, but that doesn't seem practical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectionBarControl.CommandParameterno longer represented an arbitrary command parameter; it consistently carried the active selection model. This change renames the control API toSelectionand updates the consumers so the selection flow remains explicit at every binding site.Control API
CommandParametertoSelectioninSelectionBarControl.Internal control bindings
Selectioninto play, play-next, add-to-queue, and remove commands.Selectionas its data context.Consumer updates
CommandParameter="{x:Bind ViewModel.Selection}"withSelection="{x:Bind ViewModel.Selection}"at allSelectionBarControluse sites, including Home and Play Queue surfaces.