Repository navigation
spec 019: CLUSTER UPDATE EXTENSION keeps what it does not name - #20
Merged
Merged
Conversation
An update rewrote the item's repository (resolved again with no FROM, which its grammar did not take: moved on a node trusting one repository, refused on one trusting several) and its comment (written empty). Now an update without FROM keeps the item's repository (still one the node trusts), without COMMENT its comment; FROM moves it. Found by hugr-platform spec 010's review (the console's update form). The install test takes postgres_scanner as DuckDB publishes it for this build's version and platform (DuckDB v2.0.0 is released): every build runs it, not only one that makes the scanner. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdLs2iBQygBKtsApdH9Sxi
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdLs2iBQygBKtsApdH9Sxi
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LdLs2iBQygBKtsApdH9Sxi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by hugr-platform spec 010's review: the console's update form inherits this. Fixed at the owner's request.
Before: an update rewrote two things it did not name.
FROM, and the update's grammar took none. On a node trusting one repository the item silently moved to it. On a node trusting several, every update was refused.Now:
FROMkeeps the item's repository. That repository must still be trusted; otherwise the refusal names it and asks forFROM.COMMENTkeeps the comment.FROMon an update moves the item to another trusted repository.Test (
test/cpp/test_acl_cluster_install.cpp):FROMan untrusted repository is refused and writes nothing;FROMa trusted one moves the item;The test now takes
postgres_scanneras DuckDB publishes it for this build's version and platform: DuckDB v2.0.0 is released, atextensions.duckdb.org/v2.0.0/<platform>. So every build runs the test, not only one that makes the scanner. It is skipped only when the extension cannot be fetched.Locally:
make test-cppandtest/sql/*all pass.docs/cluster.mdgives the update's grammar.🤖 Generated with Claude Code
https://claude.ai/code/session_01LdLs2iBQygBKtsApdH9Sxi