Small Torch 2.14 fixes - #787
Merged
Merged
Conversation
danieldk
commented
Aug 26, 2026
danieldk
commented
Member
- Set sycl-tla version for oneAPI 2026.1.0.
- Switch from loose CUDA architecture intersection to strict.
These cause a lot of problems, no gain since we are explicitly listing all capabilities.
sayakpaul
approved these changes
Aug 26, 2026
sayakpaul
left a comment
sayakpaul
left a comment
Member
There was a problem hiding this comment.
Really nice especially the test!
| # Determine CUDA architectures | ||
| if(KERNEL_CUDA_CAPABILITIES) | ||
| cuda_archs_loose_intersection(_KERNEL_ARCHS "${KERNEL_CUDA_CAPABILITIES}" "${CUDA_ARCHS}") | ||
| cuda_archs_intersection(_KERNEL_ARCHS "${KERNEL_CUDA_CAPABILITIES}" "${CUDA_ARCHS}") |
Member
There was a problem hiding this comment.
Would this have any backward breaking behaviour? I am guessing not because we only maintain the last two recent PyTorch versions. But just checking.
Member
Author
There was a problem hiding this comment.
It should be fine, since in practice we have every CUDA capability listed anyway.
| # We have special handling for x.0a, if x.0a is in `SRC_CUDA_ARCHS` and x.0 is | ||
| # in `TGT_CUDA_ARCHS` then we should remove x.0a from `SRC_CUDA_ARCHS` and add | ||
| # x.0a to the result (and remove x.0 from TGT_CUDA_ARCHS). | ||
| # `<major>.<minor>[letter][+PTX]` compute the intersection with the |
Member
There was a problem hiding this comment.
Would be nice to also include the example of megablocks that triggered this.
Member
Author
There was a problem hiding this comment.
Seems too specific for the docs, but it is covered in the tests below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.