Repository navigation
Финальный отсчёт - #12
Merged
Merged
Conversation
MowlCoder
reviewed
May 18, 2026
| this.server.use( | ||
| authenticateMiddleware.execute.bind(authenticateMiddleware), | ||
| ); | ||
| this.server.use(cors()); |
There was a problem hiding this comment.
cors нужно выше вещать, чуть ли не самым первым
Comment on lines
+19
to
+31
| const storage = diskStorage({ | ||
| destination: this.uploadDirectory, | ||
| filename: (_req, file, callback) => { | ||
| const fileExtention = extension(file.mimetype); | ||
| const filename = nanoid(); | ||
| callback(null, `${filename}.${fileExtention}`); | ||
| }, | ||
| }); | ||
|
|
||
| const uploadFilesMiddleware = multer({ storage }).array( | ||
| this.fieldName, | ||
| this.maxCount, | ||
| ); |
There was a problem hiding this comment.
Поправь если не прав, но я не вижу валидацию максимального размера файла, такое даже если нет в ТЗ, лучше добавить, чтобы не загрузили огромный файл
Comment on lines
+1
to
+2
| export const STATIC_UPLOAD_ROUTE = '/upload'; | ||
| export const STATIC_FILES_ROUTE = '/static'; |
There was a problem hiding this comment.
Почему храним константы тут, а потом используем в shared? Думаю лучше тогда их в shared переместить, иначе у тебя shared пакет зависит от src/rest, что не правильно, shared не должны зависеть от бизнес слоя, каковым является rest в src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎓 Финальный отсчёт