Repository navigation
fix: sort __MODULE__ first among aliases - #117
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe alias ordering comparison now converts atom names to lowercase before comparison. Tests now expect Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adjusts alias ordering so MODULE is sorted first, with corresponding test updates. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
|
Hello @woylie , thank you for the fix. Sorry it took a little longer to merge it, but now a new version is released. |
resolves #116
Solved by converting the module name to uppercase instead of lowercase, which matches what Credo does:
https://github.com/rrrene/credo/blob/89457a1608a5b027e508d500f53748aef99d4f1d/lib/credo/check/readability/alias_order.ex#L133
Summary by CodeRabbit
__MODULE__and related aliases appear before regular aliases.:asand multi-alias declarations.