Deploy last remaining changes from Codeando - #114
Merged
Merged
Conversation
use internationalized path to the search page
consider locale when searching for related news
spwoodcock
reviewed
Aug 4, 2026
|
|
||
| @register.simple_tag(takes_context=True) | ||
| def get_search_page(context): | ||
| return SearchPage.objects.live().filter(locale=context['page'].locale).first().specific |
Member
There was a problem hiding this comment.
We need a guard here.
This assumes context['page'] exists, but we get a 500 error if it doesn't.
All pages must have a locale set e.g. /en. Loading the page without that means that the page context doesn't exist, hence error 👍
We should also guard the .first usage here. An improvement would be:
@register.simple_tag(takes_context=True)
def get_search_page(context):
page = context.get("page")
if page is None:
return None
search_page = SearchPage.objects.live().filter(locale=page.locale).first()
return search_page.specific if search_page else None
Member
There was a problem hiding this comment.
I guess it was the redirects on production that result in this error, and meant it didn't show during local tests? Good job we have a staging env now, ey!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.