Repository navigation
chore: allow hotdata 0.8.0, release 0.3.2 - #38
Conversation
hotdata 0.8.0 (the per-load-key release) is additive — every symbol this backend imports resolves unchanged — so widen the SDK pin from >=0.7,<0.8 to >=0.7,<0.9 with no code change. Unblocks the dlt destination's [ibis] extra, which needs to coexist with hotdata 0.8.0.
There was a problem hiding this comment.
Clean dependency cap bump. Verified all imported hotdata symbols in src/ibis_hotdata/http.py match those listed in the PR description, version is consistent across pyproject.toml, uv.lock, and CHANGELOG.md, and __version__ is sourced from package metadata (no manual bump needed).
|
Reviewed this against a live check, not just the description — a couple of findings: CI is actually failing (blocking)
Root cause: SDK 0.8.0 adds The fix is small — add Good news: not a real backward-compat breakI forced Minor nit (non-blocking)This PR bundles the dependency bump with the version bump + CHANGELOG dating in one PR. The convention we've used on the last couple of releases (see #35 / #37) is to keep those separate — a fix/chore PR, then a dedicated |
hotdata 0.8.0 makes default_schema a required field on CreateDatabaseResponse, DatabaseDetailResponse, and DatabaseSummary. The test fixtures predate it, so pydantic rejected them on parse. Add default_schema to the mocked response bodies (value is illustrative — the backend reads its default schema from connect params, not the response).
|
Verified the fix independently (not just relying on green CI):
CI is green across all 5 Python versions too. This looks good to merge from my side — nothing further blocking. The bundled-release-PR nit from my earlier comment still stands but isn't a blocker for a change this size. |
What
Widens the
hotdataSDK pin>=0.7,<0.8→>=0.7,<0.9so this backend can run alongsidehotdata 0.8.0(the per-load-key release). Releases 0.3.2.Why it's safe (no code change)
hotdata 0.8.0is additive — it adds akeyfield on the load-request model and a fork endpoint; nothing is removed or renamed. Verified everyhotdatasymbol this backend imports (ApiClient,Configuration,DatabasesApi,ApiException,QueryRequest,CreateDatabaseRequest,DatabaseDefaultSchemaDecl,DatabaseDefaultTableDecl,LoadManagedTableRequest,AsyncQueryResponse) resolves unchanged against 0.8.0. Mirrors the0.3.1cap bump.Unblocks
hotdata-dlt-destination's[ibis]extra pinshotdata-ibis>=0.3.1,<0.4and now requireshotdata 0.8.0; its--all-extraslock can't resolve until this ships (the connector's existing pin auto-picks0.3.2).Tests
No
srcchange.uv.lockregenerated (hotdata → 0.8.0). CI (uv sync --all-groups+ruff+pytest) unaffected.