Repository navigation
Fix ~1s slowdown on large query results - #67
Merged
Merged
Conversation
The Results API answers 202 with Retry-After: 1 while a result persists, but persistence usually finishes ~100ms later. Honoring it made results too large to inline ~1s slower than v1.0.4 (1583ms vs 552ms median for a 56k-row query). Keep the 50ms backoff instead.
eddietejeda
requested review from
shefeek-jinnah
and removed request for
a team
October 24, 2026 22:44
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#66 started honoring
Retry-Afterwhile pollingGET /v1/results/{id}. The API sendsRetry-After: 1while a result is persisting, but persistence usually finishes ~100ms later, so every result too large to inline waited an extra second.This goes back to the 50ms → 2s backoff for result polling.
Retry-Afteris still honored for 429 retries.Benchmark (live API, through Grafana, v1.0.4 vs this branch, median)
Other queries are unaffected; results were identical to v1.0.4 in every case.
Testing
go test ./pkg/...(the test server now sendsRetry-After: 1; the suite still runs in ~0.4s).