Repository navigation
Release 1.0.4: clear osv-scanner high findings - #59
Merged
Merged
Conversation
eddietejeda
requested review from
rohan-hotdata
and removed request for
a team
October 19, 2026 18:34
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| "moment": "^2.31.0", | ||
| "basic-ftp": "^6.2.3", | ||
| "source-map-js": "^1.2.2", | ||
| "micromatch": "npm:picomatch@^4.0.3" |
There was a problem hiding this comment.
nit: Scope the micromatch override to eslint-webpack-plugin (not blocking).
"eslint-webpack-plugin": {
"micromatch": "npm:picomatch@^4.0.3"
}The global override replaces micromatch for every package in the tree. picomatch only provides part of the micromatch API, and micromatch(list, patterns) and micromatch.some are not in picomatch. A future dependency that calls those functions fails at runtime, and npm install gives no warning. Today eslint-webpack-plugin is the only consumer in package-lock.json, so the scoped override produces the same lockfile.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.3 release build failed Grafana's plugin validator: osv-scanner found 3 high-severity issues in
package-lock.json(all dev/build tooling). That also caused the validator's LLM review and code diff to be skipped.basic-ftp→ 6.2.3 (GHSA-c475-qrg2-pj4r, via @grafana/sign-plugin)source-map-js→ 1.2.2 (GHSA-68fv-2mgg-jv7q)braces(GHSA-vfj7-8cjw-p6xm) has no fixed release; its only consumer iseslint-webpack-plugin→micromatch. Overridemicromatchwithpicomatch, which provides the sameisMatch(str, patterns, options)the plugin uses and expands{ts,tsx}withoutbraces. Only affects development builds.The validator ignores
osv-scanner.toml, so the fix has to be in the lockfile.Verified locally: osv-scanner reports no high/critical; typecheck, lint, dev and prod builds pass.