Repository navigation
fix(ingest): cancel command exits 0 on success - #225
Merged
Merged
Conversation
cancel_import was unconditionally calling std::process::exit(1), making a successful cancel indistinguishable from a failure. Exit code 1 is reserved for terminal-failure statuses (failed, cancelled) in status / poll_ingest — the cancel command itself succeeded.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verified the control flow: on success with_spinner returns the ack and cancel_import now returns normally (exit 0); error paths still exit non-zero via e.exit(). Correct fix — exit 1 is reserved for terminal-failure statuses in status/poll_ingest, not the cancel command itself.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel_importwas unconditionally callingstd::process::exit(1), making a successful cancel look like a failure to callers and scriptsfailed,cancelled) instatus/poll_ingest— thecancelcommand itself succeededhotdata ingest cancelagainst prod after the 0.17.0 releaseTest plan
hotdata ingest cancel <id>on a pending/running import exits 0 and prints the cancelled statushotdata ingest status <id>still exits 1 when status iscancelledhotdata ingest status <id> --waitstill terminates with exit 1 on a cancelled import (not an infinite loop)