Repository navigation
fix: apply cheap WHERE conjuncts before inference #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rebuilt post filter keeps only the projection. The rebuilt post filter drops the original
FilterExec'sfetch,batch_sizeand default selectivity.Fix: copy those settings from
filteronto the builder. For example, chain.with_fetch(filter.fetch())and the matching batch size and selectivity setters. Add a test withLIMITandtarget_partitions = 1.Failure scenario:
LimitPushdownruns before this rule, because custom physical rules come after the built-in rules. With one partition,LimitPushdowncan foldGlobalLimitExecintoFilterExecasfetch = 1and then remove the limit node. This rule then rebuilds the filter withoutfetch.SELECT id FROM t WHERE id > 0 AND prompt_jev(body, 'q') > 0.5 LIMIT 1then returns every matching row. With several partitions, aCoalescePartitionsExecfetch still caps the row count. In that case, losing the filter fetch only adds paid inference.This bug exists only if
LimitPushdownin DataFusion 55 folds the limit intoFilterExec. The DataFusion source is not in this checkout, so the review did not confirm that behavior. Copyingfetchis safe in both cases.