Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by the primary-repository draft madeofpendletonwool#1012. That branch preserves the original commits, incorporates current main, and passes all 18 Rust API tests. This fork-targeted draft is closed in favor of that upstream submission.
Follow-up to madeofpendletonwool#986, targeting @honzup's
fix/stream-range-requestsbranch. The existing Range forwarding remains the foundation; credit to @honzup and @davegallant for the original fix/diagnosis. Related: madeofpendletonwool#980.Forwarding If-Range alone does not validate it in the file-serving dependency. A stale validator must produce the complete resource instead of partial bytes from a different file. Extract the authorized file-serving step into a helper, check response validators, retry without Range on mismatch, and preserve HEAD requests.
Adds regressions for full/bounded/open/suffix responses, unsatisfiable ranges, stale and matching validators, HEAD, and conditional caching, plus focused CI. Authorization and path resolution remain in the existing handler. No runtime dependency is added.
Validation: all 14 Rust API tests passed against this branch's locked dependencies, including four media-stream regressions (
cargo test --locked --manifest-path rust-api/Cargo.toml). Current-main validation was also performed during the original review. Physical iOS playback remains pending. GitHub Actions currently reportaction_requiredwith no test jobs run.This draft supplements madeofpendletonwool#986 and is intended to be folded into that PR.