Drop eslint-config-airbnb-base and cherry-pick rules#51627
Open
loganrosen wants to merge 1 commit intohome-assistant:devfrom
Open
Drop eslint-config-airbnb-base and cherry-pick rules#51627loganrosen wants to merge 1 commit intohome-assistant:devfrom
loganrosen wants to merge 1 commit intohome-assistant:devfrom
Conversation
github-actions
bot
added
Demo
Remove the unmaintained eslint-config-airbnb-base dependency (last updated Nov 2021, no flat config support) along with its FlatCompat shim infrastructure. Replace with js.configs.recommended as the base config and explicitly cherry-pick ~40 high-value safety and style rules from airbnb-base that aren't already covered by other configs. Remove 27 rule disables that only existed to suppress airbnb opinions, and 5 dead TypeScript rule disables for rules no longer in the config. Fix 4 real bugs caught by the newly added no-constant-binary-expression rule where template literals were always truthy, making fallback values unreachable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
loganrosen
force-pushed
the
drop-airbnb-base
branch
from
acc0d18 to
2aa9c41
Compare
MindFreeze
reviewed
Apr 20, 2026
Member
MindFreeze
left a comment
MindFreeze
left a comment
There was a problem hiding this comment.
I like this but since changes the linting slightly, the other from the team need to agree as well
Comment on lines
+102
to
+104
| // TODO: Enable once violations are fixed (43 instances as of 2026-04) | ||
| // "no-useless-assignment": "error", | ||
| "no-useless-assignment": "off", |
Member
There was a problem hiding this comment.
Might as well fix them in this PR, I think
wendevlin
reviewed
Apr 20, 2026
| "no-underscore-dangle": "off", | ||
| strict: "off", | ||
| "no-plusplus": "off", | ||
| // Cherry-picked safety rules (previously provided by airbnb-base) |
Member
There was a problem hiding this comment.
Suggested change
| // Cherry-picked safety rules (previously provided by airbnb-base) |
It's good for this PR to know that, but I think we don't need such comments in the codebase.
Member
I agree with this change, it brings more transparency to our linting rules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Drop the unmaintained
eslint-config-airbnb-basedependency (last updated Nov 2021, no flat config support) and itsFlatCompatshim infrastructure.What this PR does:
js.configs.recommendedas the base config@eslint/eslintrc,eslint-config-airbnb-base,eslint-plugin-importno-constant-binary-expressionrule, where template literal expressions like`${value}px`are always truthy strings, making|| fallbackunreachableno-useless-assignmentas"off"with a TODO (43 existing violations — separate cleanup PR)Type of change
Additional information
Checklist
To help with the load of incoming pull requests: