Improve/fix Insteon event handling#168663
Open
gogglespisano wants to merge 9 commits intohome-assistant:devfrom
Open
Improve/fix Insteon event handling#168663gogglespisano wants to merge 9 commits intohome-assistant:devfrom
gogglespisano wants to merge 9 commits intohome-assistant:devfrom
Conversation
This fixes bug home-assistant#162946. Insteon sensor events are missing the data about the event. In the case of the leak sensor, the heartbeat event looked the same regardless of whether it was from the device heartbeat or the heartbeat manager missed heartbeat event. This needs pyinsteon pull request pyinsteon/pyinsteon#442 in order to have the full data in the event. This also cleans up the event names by removed the redundant "event" suffix on most of the events and also simplifies the event processing code. Both the existing events and the new events without the "event" suffix are fired for compatibility with existing automations. A deprecation warning is added to the event data.
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-needed
dependency
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @teharris1, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Insteon event handling by propagating additional low-level event details into Home Assistant events and introducing cleaner event names (without the redundant _event suffix) while attempting to preserve backward compatibility.
Changes:
- Refactors Insteon event firing to enrich event payloads (battery/heartbeat/moisture/button).
- Implements “new” event names (suffix removed) and also fires legacy events with a deprecation notice.
- Updates Insteon constants to support the new event payload fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
homeassistant/components/insteon/utils.py |
Refactors event subscription and HA event firing, adds new event payload fields and legacy event emission. |
homeassistant/components/insteon/const.py |
Removes old button event constants and adds new event payload field keys. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gogglespisano
commented
Apr 20, 2026
Author
gogglespisano
left a comment
gogglespisano
left a comment
There was a problem hiding this comment.
Made the suggested code changes
rename heartbeat to heartbeat_missed. make a legacy copy of the event schema. only send legacy event if it's different from new event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Insteon sensor events are missing the data about the event.
This change passes the lower level event data into the HA event.
In the case of the leak sensor, the heartbeat event looked the same regardless of whether it was from the device heartbeat or the heartbeat manager missed heartbeat event, resulting in the heartbeat state never changing to "Problem" when the heartbeat is missed.
This also cleans up the event names by removed the redundant "event" suffix on most of the events and also simplifies the event processing code.
Both the existing events and the new events without the "event" suffix are fired for backwards compatibility with existing automations. A deprecation warning is added to the event data.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: