Bring nobo_hub to Bronze quality scale#168638
Open
oyvindwe wants to merge 4 commits intohome-assistant:devfrom
Open
Bring nobo_hub to Bronze quality scale#168638oyvindwe wants to merge 4 commits intohome-assistant:devfrom
oyvindwe wants to merge 4 commits intohome-assistant:devfrom
Conversation
- Add NoboBaseEntity to deduplicate the hub-callback wiring across climate, sensor, and select. - Add the quality_scale.yaml tracker and declare "bronze" in the manifest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR brings the nobo_hub integration up to Bronze quality scale requirements by adding quality scale metadata, improving entity structure, and tightening test fixtures.
Changes:
- Add
quality_scale.yamland set"quality_scale": "bronze"in the integration manifest; update hassfest lists accordingly. - Introduce
NoboBaseEntityand refactorclimate,select, andsensorplatforms to inherit shared hub callback wiring. - Improve UX/test robustness by adding
data_descriptionstrings and ensuring test config entries haveruntime_datapopulated.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/components/nobo_hub/conftest.py | Ensures mocked setup populates entry.runtime_data to support real unload behavior. |
| script/hassfest/quality_scale.py | Removes nobo_hub from “without quality scale file/scale” exception lists. |
| homeassistant/components/nobo_hub/strings.json | Adds data_description for config/options flow fields. |
| homeassistant/components/nobo_hub/sensor.py | Moves temperature sensor to NoboBaseEntity for shared callback handling. |
| homeassistant/components/nobo_hub/select.py | Moves select entities to NoboBaseEntity for shared callback handling. |
| homeassistant/components/nobo_hub/quality_scale.yaml | Adds integration quality scale rule tracking file. |
| homeassistant/components/nobo_hub/manifest.json | Declares integration quality scale as Bronze. |
| homeassistant/components/nobo_hub/entity.py | Adds shared base entity implementing hub callback registration/deregistration. |
| homeassistant/components/nobo_hub/climate.py | Moves climate entity to NoboBaseEntity for shared callback handling. |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Context: this is the last of 3 PRs to bring
nobo_hubto Bronze quality scale.quality_scale.yamltracking all Bronze/Silver/Gold/Platinum rules).NoboBaseEntityin a newentity.pyand refactor theclimate,select, andsensorplatforms to inherit from it.data_descriptionto every config and options flow field instrings.json.mock_setup_entrytest fixture to populateentry.runtime_dataso the realasync_unload_entrydoesn't trip during teardown.No behavioural changes. Silver, Gold, and Platinum work will follow in subsequent PRs.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: