Expose Evohome faults as binary sensors of problem class#168634
Expose Evohome faults as binary sensors of problem class#168634zxdavb wants to merge 9 commits intohome-assistant:devfrom
Conversation
Exposes active faults from Evohome zones and DHW as Problem binary sensors, providing a dedicated entity for fault monitoring in place of extra_state_attrs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zxdavb
changed the title
| class EvoDhwFaultSensor(EvoFaultSensorBase): | ||
| """Fault sensor for a DHW controller.""" | ||
|
|
||
| _attr_name = "DHW faults" |
There was a problem hiding this comment.
The names should be translatable.
There was a problem hiding this comment.
Whoops - the intention was to take _attr_name out altogether!
Very recently, when I did translatable names in a similar PR, joostlek suggested it was pragmatic to remove it from that PR: #167550 (comment)
Hmm, in a way I like the translation, but given that the rest of the integration isn't translated at all, I'd maybe just opt to say, keep it simple for yourself and just do it like the other entities
Reason:
- Evohome is an older integration, and much of it that should be translatable is not
- the complexity of handling dynamic zone names vs @cached_property
My plan to address translation en-masse, when I go for platinum. Hope that's OK?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Ps. I like the idea of this. These multi problem sensors are annoying. I wish there was a way to display the error list in frontend though. |
2 participants
Proposed change
Add binary sensors to Evohome that expose active system faults as
PROBLEMs withextra_state_attributescontaining the details of any faults.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: