Frontier silicon: use correct command to restart stopped stream#168633
Open
wlcrs wants to merge 3 commits intohome-assistant:devfrom
Open
Frontier silicon: use correct command to restart stopped stream#168633wlcrs wants to merge 3 commits intohome-assistant:devfrom
wlcrs wants to merge 3 commits intohome-assistant:devfrom
Conversation
home-assistant
bot
added
bugfix
cla-signed
integration: frontier_silicon
small-pr
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Frontier Silicon media player integration so that restarting playback from a stopped stream uses the device-specific transport command behavior discussed in #164643.
Changes:
- Track the device
PlayStateon update so transport logic can branch on STOPPED vs other states. - Change
async_media_playto sendstop()(instead ofplay()) when the last known state isPlayState.STOPPED.
Comment on lines
284
to
+291
| async def async_media_play(self) -> None: | ||
| """Send play command.""" | ||
| await self.fs_device.play() | ||
| if self.__play_state == PlayState.STOPPED: | ||
| # The 'play' command only seems to work when the current stream is paused. | ||
| # We need to send a 'stop' command instead to resume a stopped stream. | ||
| await self.fs_device.stop() | ||
| else: | ||
| await self.fs_device.play() |
There was a problem hiding this comment.
Query the current play status (or otherwise avoid relying on cached state) before choosing between stop() and play(). async_media_play bases its decision on self.__play_state, which is only updated during async_update and can be out of date when the user presses play (or still set from a prior run after an update failure), potentially sending the wrong transport command.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Frontier silicon devices require us to send a 'stop' command to restart a stopped stream instead of sending a 'play' command.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: