Skip to content

Use runtime_data in ws66i integration#168628

Open
epenet wants to merge 1 commit intodevfrom
epenet/ws66i-runtime-data
Open

Use runtime_data in ws66i integration#168628
epenet wants to merge 1 commit intodevfrom
epenet/ws66i-runtime-data

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 20, 2026

Proposed change

Migrate the ws66i integration to use ConfigEntry.runtime_data instead of storing data in hass.data[DOMAIN][entry.entry_id].

  • Added a Ws66iConfigEntry typed alias in models.py (alongside the existing Ws66iData dataclass).
  • Updated __init__.py and media_player.py to use the typed config entry and entry.runtime_data.
  • Updated the init test to check ConfigEntryState instead of hass.data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown

Hey there @ssaenger, mind taking a look at this pull request as it has been labeled with an integration (ws66i) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ws66i can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ws66i Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@epenet epenet marked this pull request as ready for review April 20, 2026 14:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the ws66i integration from storing per-entry state in hass.data to using ConfigEntry.runtime_data, aligning it with current Home Assistant integration patterns.

Changes:

  • Introduces a typed config entry alias (Ws66iConfigEntry = ConfigEntry[Ws66iData]) in models.py.
  • Updates __init__.py and media_player.py to read/write integration data via entry.runtime_data.
  • Adjusts the init/unload test to validate ConfigEntryState rather than hass.data.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/ws66i/models.py Adds the typed Ws66iConfigEntry alias for runtime_data usage.
homeassistant/components/ws66i/__init__.py Stores Ws66iData on entry.runtime_data and uses it during unload.
homeassistant/components/ws66i/media_player.py Fetches Ws66iData from config_entry.runtime_data during platform setup.
tests/components/ws66i/test_init.py Updates assertions to validate config entry lifecycle via ConfigEntryState.

Copy link
Copy Markdown
Member

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @epenet 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants