Map DPAD_DOWN to TAB in HAWebViewActivity

[TimoPtr]

Summary

DPAD_DOWN to TAB remapping for Android TV

• Extracted DPAD_DOWN mapping into HAWebView.kt
• Applied automatically in HAWebView's factory block
• Removed the dispatchKeyEvent override from WebViewActivity

Checklist

• New or updated tests have been added to cover the changes following the testing guidelines.
• The code follows the project's code style and best_practices.
• The changes have been thoroughly tested, and edge cases have been considered.
• Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

[dshokouhi]

you know i havent had a chance to recheck this but I wonder this is still necessary? at the time it was used to help android tv users login because they couldnt even switch to the password field using the remote control. This was before the frontend login screen was updated to be more modern. I do recall we have a bug from a keyboard only user getting stuck due to this one too.

[Copilot]

Pull request overview

This PR moves the Android TV DPAD_DOWN → TAB navigation workaround from the legacy WebViewActivity key dispatch override into the shared HAWebView composable, so the behavior is applied at the WebView level whenever HAWebView is used.

Changes:

• Removed dispatchKeyEvent override (and KeyEvent import) from WebViewActivity
• Added a WebView.remapDpadDownToTab() helper using an OnKeyListener
• Applied the remapping automatically in HAWebView’s AndroidView.factory block and documented the behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
app/src/main/kotlin/io/homeassistant/companion/android/webview/WebViewActivity.kt	Removes the Activity-level DPAD_DOWN workaround, relying on WebView-level handling instead
app/src/main/kotlin/io/homeassistant/companion/android/util/compose/webview/HAWebView.kt	Adds and applies DPAD_DOWN → TAB remapping via OnKeyListener, with updated KDoc

[Copilot]

This introduces new key-handling behavior (DPAD_DOWN -> TAB) but there is no automated test covering it. Please add a unit/Robolectric or Compose UI test that verifies a DPAD_DOWN key event dispatched to the WebView results in a TAB key event being forwarded, to prevent regressions across Android TV and non-TV devices.

[TimoPtr]

you know i havent had a chance to recheck this but I wonder this is still necessary? at the time it was used to help android tv users login because they couldnt even switch to the password field using the remote control. This was before the frontend login screen was updated to be more modern. I do recall we have a bug from a keyboard only user getting stuck due to this one too.

Thanks for jumping in I remember discussing about it but I didn't remember what was the outcome .... So maybe it is not relevant anymore.