Refactor SocketClient connection handling and error logging#1169
Open
elupus wants to merge 1 commit intohome-assistant-libs:masterfrom
Open
Refactor SocketClient connection handling and error logging#1169elupus wants to merge 1 commit intohome-assistant-libs:masterfrom
elupus wants to merge 1 commit intohome-assistant-libs:masterfrom
Conversation
Avoid nested partial exception capture and let exception propagate to where we can make an informed choices. We don't need to catch unexpected errors we can't do anything deep in nested functions. It's better for them to propagate out to where we can do something about them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid nested partial exception capture and let exception propagate to where we can make an informed choices. We don't need to catch unexpected errors we can't do anything deep in nested functions. It's better for them to propagate out to where we can do something about them.
Also ensure we don't hammer hosts if we fail with unexpected exception wait for 5 seconds before attempting to reconnect.