Allow connecting to chromecast over IPv6#1162
Open
Mathis-6 wants to merge 3 commits intohome-assistant-libs:masterfrom
Open
Allow connecting to chromecast over IPv6#1162Mathis-6 wants to merge 3 commits intohome-assistant-libs:masterfrom
Mathis-6 wants to merge 3 commits intohome-assistant-libs:masterfrom
Conversation
Author
|
damn i didn't saw #861 which is much more complete than my PR. |
Collaborator
Read the reviews |
Collaborator
|
Ps. This looks much easier to review since its scope is smaller. |
Author
Can it be merged then ? |
Collaborator
|
Any chance you can try to refactor this to use socket.create_connection instead. That also handles both variants and is a bit higher level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we can only connect to the chromecasts over IPv4 because
socket.AF_INETis hardcoded for the socket.This PR adds an automatic detection to choose from AF_INET6 or AF_INET, depending if the address contains colons or not