ci: drop obsolete Releases/Pages link-check excludes - #40
Open
andrewcb22 wants to merge 1 commit into
Open
Conversation
v0.1.0 shipped 2026-07-28, so the Releases and Pages URLs excluded from the weekly link check now resolve (verified: 200 and a 301 redirect, respectively). Drop those two excludes so the check actually covers them. Left the crates.io exclude in place: surface-cli hasn't been published to crates.io yet (verified 404 with a browser user agent), so removing it now would just make the weekly check fail on something that isn't actionable. Updated the comment to say so. Fixes holistic-ai#35
andrewcb22
requested review from
as-koshiyama,
kleyt0n and
umar-hai
as code owners
July 31, 2026 01:51
kleyt0n
reviewed
Jul 31, 2026
| --no-progress | ||
| --max-concurrency 8 | ||
| --exclude '^https://github\.com/holistic-ai/surface/releases' | ||
| --exclude '^https://crates\.io/crates/surface-cli' |
Contributor
There was a problem hiding this comment.
Why not delete this link also?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#35 — the weekly link-check workflow excludes Releases, crates.io, and Pages URLs with a comment saying to drop them after the first release. v0.1.0 shipped 2026-07-28.
Change
Removes the
ReleasesandPagesexcludes, since both now resolve.Kept the
crates.ioexclude, unlike the issue's literal checklist: verified the v0.1.0 release didn't include acargo publishstep, socrates.io/crates/surface-clistill 404s (checked with a browser user agent — a plaincurlgets a 403 from Cloudflare that's misleading here). Removing it now would just turn the weekly check red on something no one can act on. Updated the inline comment to explain and left a pointer to drop it once the crate is actually published.Testing
curl(with a browser UA) against all three previously-excluded URLs:surface-cli) againstCargo.tomland the README badge/install instructions.lycheeitself; the diff is a 4-line YAML change with no structural edits, reviewed by hand.Fixes #35