Repository navigation
hmp-npcs: Remove a destroyed NPC by its normalized id - #16
Open
spadieri85 wants to merge 1 commit into
Open
spadieri85 wants to merge 1 commit into
spadieri85 wants to merge 1 commit into
Conversation
destroy looked the entry up with the normalized integer id but deleted it with the raw argument. An id that arrives as a numeric string, as it can across a resource export, found and destroyed the NPC yet left it in the registry: it kept counting against the resource's limit and clear and stop destroyed it a second time.
spadieri85
force-pushed
the
hmp-npcs-destroy-normalized-id
branch
from
October 17, 2026 23:07
77ad41c to
ed11b6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroylooked the entry up withinteger(id)but deleted it with the raw argument. When the id arrives as a numeric string (e.g. across a resource export), the NPC is destroyed but stays inmanaged: it keeps counting againstmaximumPerResource, andclear/stopdestroy it a second time.The fix deletes by the normalized key. The test destroys an NPC by its string id and checks the registry count, a second
destroyand thatstopdoesn't destroy it again.npm run verifypasses.