Repository navigation
test(dependabot-config): assert the gate's remaining branches and clear its coverage-floor entry - #317
Conversation
…ar its coverage-floor entry parseDependabot and dependabotProblems carried nine branches the suite never executed: the unreadable top-level line, bodies under registries:, a bad first key on a list item, [...] flow lists, an empty flow-map part, the no-package-ecosystem rejection, directories: reaching the rules and listDir's missing-directory catch. Each is now pinned by a fixture so the ratchet entry can go. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read the three new fixtures against the parser and rules at c3b08e4; looks correct to me.
scripts/dependabot-config.test.mjs:283(- updatesat indent 0) hits theunreadablepush at line 91; theregistries:body returns through line 97 without touchingupdates;{weekly}fails thekvregex insetKey(line 129) and surfaces asunreadable flow map; the trailing-comma flow list and{interval: weekly, }are absorbed byfilter(Boolean)/if (!part.trim()) continueat lines 124/128.:294— traced the fixture line numbers: items start at 3, 6 and 12, soentry has no package-ecosystemon line 3 and the/siteduplicate against line 6 are the only two problemsdependabotProblemscan produce forexpected: ["npm"].:305— a throwingreaddirSynclands inlistDir's catch (line 59) andaction.yamlalone impliesgithub-actionsvia the marker at line 46.
Ran node --test scripts/dependabot-config.test.mjs scripts/coverage-floor.test.mjs: 30/30 pass. Re-adding "scripts/dependabot-config.test.mjs": 9 to TEST_HELPER_BASELINE makes the floor gate fail with 0 dead ranges left, baseline allows 9, so the ratchet is pinned in both directions as the body says. Test-only change, no behaviour or docs affected; only tide is still pending.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive
Bot
removed
role/trusted
Summary
scripts/dependabot-config.test.mjsis the only thing that notices when.github/dependabot.ymlstops meaning anything — and nine of its own branches were never executed by the suite, socoverage-floor.test.mjscarried aTEST_HELPER_BASELINEentry of 9 for it. The unexecuted ranges were mostly the gate's own rejection paths: an unreadable indent-0 line, bodies under a non-updates:section such asregistries:, a bad first key on a list item,[…]flow lists, an empty flow-map part ({interval: weekly, }), theentry has no package-ecosystemrejection, adirectories:list reaching the rules (not just the parser), andlistDir's missing-directory catch. A regression in any of them would have kept the live test green.Three fixture tests pin each of those branches and the ratchet entry is deleted, following the pattern of #304 and #312. With the entry restored the floor gate fails with
0 dead ranges left, baseline allows 9; with it removed the gate passes, so the change is pinned in both directions.Checks run locally
node --test scripts/*.test.mjs(818 → 821 pass;coverage-floor.test.mjs14/14)scripts/check-links.test.shscripts/check-redirects.test.shscripts/check-links.sh --external-warn/scripts/check-redirects.sh— not run; no page or redirect changedChecklist
git commit -s)Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88