Skip to content

[reviewer] Review backlog (docs-currency): stripTrailingBlankLines doc comment says it makes no additional git call #16145

Closed
#16157
Closed
[reviewer] Review backlog (docs-currency): stripTrailingBlankLines doc comment says it makes no additional git call#16145
#16157
Labels
agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Description

@hivecommons-hive
hivecommons-hive
bot
opened on Nov 1, 2026

Blocked on PR #16142. This finding came from reviewing PR #16142 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16142.

PR: #16142 (#16142)
Perspective: docs-currency
Severity: info (P3)
Finding: stripTrailingBlankLines doc comment says it makes no additional git call
Evidence: src/crux/pushbroker/pushbroker.go:662

hive/src/crux/pushbroker/pushbroker.go

Line 662 in e28fae7

// Only files still present on disk are considered — a changed file that was

Pre-existing: the doc comment at src/crux/pushbroker/pushbroker.go:662-664 says the helper 'deliberately makes no additional git call', yet the function runs git add and git commit --amend --only (pushbroker.go:697-702). The PR touches the amend line but not the comment. Harmless inaccuracy in a Go doc comment, not operator-facing; tidy up opportunistically.

Fingerprint: b2c276d9437d3b33cb8fd19bc9a7bf216428a8816434cfdc979d8bdf9dacb3a3

filed by Hive review backlog

Activity

  1. hivecommons-hive
    added
    agent/reviewerFiled by the reviewer agent
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    and removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 1, 2026

  2. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Nov 1, 2026 – with hivecommons-hive
    ContributorAuthor

    Same file as #16144: both cite src/crux/pushbroker/pushbroker.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. github-actions
    added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 1, 2026
  4. hivecommons-hive
    removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 1, 2026

  5. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Nov 1, 2026 – with hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16142 is no longer open. This issue is actionable again.

  6. hivecommons-hive
    added
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 1, 2026
  7. github-actions
    added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 1, 2026

  8. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Nov 1, 2026 – with hivecommons-hive
    ContributorAuthor

    Unblocked: #16142 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  9. hivecommons-hive
    added
    hive/claimed-by-scanner
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 1, 2026

  10. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Nov 1, 2026 – with hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  11. hivecommons-hive
    added
    stage/030-pr-in-progressAn agent kick is running; no PR yet
    stage/040-covered-by-prAn open PR covers this issue
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    stage/030-pr-in-progressAn agent kick is running; no PR yet
    hive/claimed-by-scanner
    stage/040-covered-by-prAn open PR covers this issue
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 1, 2026

  12. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Nov 2, 2026 – with hivecommons-hive
    ContributorAuthor

    Fixed by #16157 (merged cc32210). Closing. Reply /reopen if the problem persists.

  13. hivecommons-hive
    closed this as completedin #16157on Nov 2, 2026
  14. hivecommons-hive
    removed
    stage/040-covered-by-prAn open PR covers this issue
    on Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions