[Karibhou]

📌 Fixes

Fixes #571

---

📝 Summary of Changes

withCodeProtected in scripts/mdx-to-markdown.ts masked fenced code with its own regex (/^([ \t]*)({3,}|~{3,})[\s\S]?^\1\2[ \t]$/gm). That regex ignored two rules FenceTracker` enforces for the block pass since #570:

• a backtick run whose info string contains a backtick (```not`a`fence) is not a fence opener;
• a closer may be longer than the opener.

So the block pass and the inline link/image/brace pass disagreed on what is code, and a prose link after such a line could be masked from the link rewrite if a later fence followed.

withCodeProtected now builds its fence slots from splitFencedSegments (the shared rule) and keeps the inline-code masking for the prose segments only. A fence's trailing newline stays outside the placeholder so ^-anchored patterns (IMPORT_RE, EXPORT_RE) still see the next line's start.

One consequence: an unclosed fence is now masked to the end of the content, matching how convertBlocks already treats it.

Changes Made

• Fixed withCodeProtected to use splitFencedSegments
• Added tests for both divergent cases in scripts/mdx-to-markdown.edge-cases.test.ts. They failed before the fix (link left as /install/) and pass after it
• Changelog fragment changelog.d/fixed-571-mdx-inline-pass-fence-rule.md

Checklist

• I have reviewed the project's contribution guidelines.
• I have performed a self-review of my changes.
• I have written unit tests for the changes (if applicable).
• I have tested the changes locally and ensured they work as expected. Ran npx vitest run --coverage (1406 passed, thresholds met), npm run type-check, ESLint, Prettier and markdownlint on the touched files. typos was not run because it is not installed locally.
• All CI checks are passing.

Security Considerations

Not applicable: build-time sync script only.

— hive: backend=omp model=anthropic/claude-opus-5-5

---

🐝 Hive Agent: contributor | SHA: 08397a6

[netlify]

👷 Deploy request for hivecommons-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	08397a6

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

Looks correct to me.

Read withCodeProtected (scripts/mdx-to-markdown.ts:257-271) against splitFencedSegments/FenceTracker (scripts/markdown-fences.ts:28-73) and both call sites (mdx-to-markdown.ts:289-318):

• Segments concatenate back to the original text exactly, so the placeholder swap is lossless; the inline `…` mask now runs only on prose segments, which is the same per-line behaviour as before.
• Keeping the fence's trailing \n outside the placeholder is what lets IMPORT_RE/EXPORT_RE (^…$ with m) still match on the line after a fence — checked that neither anchored pattern can match inside \u0000N\u0000.
• The two new tests fail on main's withCodeProtected (link left as /install/) and pass at 08397a6; the full mdx-to-markdown* suite passes (51 tests).

The one behaviour change not covered by a test — an unclosed fence now masking to EOF — matches convertBlocks, as the body says, and is the consistent choice.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the tree at 08397a6, not just the diff. This looks correct to me.

What I verified

• scripts/mdx-to-markdown.ts:257-270 — withCodeProtected now derives fence slots from splitFencedSegments (scripts/markdown-fences.ts:60-73), which is the same FenceTracker that convertBlocks already drives at mdx-to-markdown.ts:177-197. So the block pass and the inline pass now share one definition of "fenced", which is the actual bug in [reviewer] Review backlog (correctness): withCodeProtected still masks fences with its own regex, diverging from FenceTracker #571.
• The trailing-newline handling (seg.text.slice(0, len - nl.length) + nl) keeps the placeholder on its own line, so the ^-anchored IMPORT_RE / EXPORT_RE (mdx-to-markdown.ts:55-56) used by the first withCodeProtected caller at :289 still see the next line's start — same shape as the old ^…$ regex, which also excluded the closer's newline.
• Inline-code masking is now per prose segment; /[^\n]*/` cannot span a newline, so splitting at fence boundaries changes nothing for it.
• Both new tests in scripts/mdx-to-markdown.edge-cases.test.ts:197-212 fail on main (link left as /install/) and pass on this head. Full npx vitest run: 1406/1406, twice.

One behaviour change worth a maintainer's eye, already called out in the body: an unclosed fence is now masked to end-of-content, matching convertBlocks. That is the consistent choice; just noting it is a visible change rather than a pure refactor.

I have not approved or merged anything — this is a comment only.

Evidence bundle `#57208397a6` sha256:405bf76c7e5ac582044a43897bf7a1c781ea92139fefe855ccf61dcbe404b37b — download from the dashboard or `hivectl review evidence #572`.

[hivecommons-hive]

Merged by hive contributor-lane auto-merge: CI green for ≥10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry.