Skip to content

[reviewer] Review backlog (style): mdx-to-markdown.ts keeps its own fence tracker and FENCE_RE #569

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #568.

PR: #568 (#568)
Perspective: style
Severity: low (P3)
Finding: mdx-to-markdown.ts keeps its own fence tracker and FENCE_RE
Evidence: scripts/mdx-to-markdown.ts:174

function findClose(lines: string[], from: number, name: string): number {

findClose (lines 174-202) and convertBlocks (lines 204-226) each hand-roll the same opener/closer rule (same marker char, closer length >= opener length, empty info) that markdown-fences.ts isFenceCloser already encodes, and define their own FENCE_RE. With this PR the repo has three independent fence trackers. Pre-existing and not touched here; a follow-up could route mdx-to-markdown through the shared helpers.

Fingerprint: ffcacd80ccd918df92c4f1fc880ce8f12562c02958d1c9a320591f6dc394eb18

filed by Hive review backlog

Activity

  1. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  2. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

  3. added a commit that references this issue on Nov 1, 2026
    4842836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions