Align initial Platform implementation with spec - #132
Open
dolanske wants to merge 6 commits into
Open
Conversation
dolanske
marked this pull request as ready for review
August 3, 2026 07:48
dolanske
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the web platform controller based on #36
It intentionally leaves out history and desktop implementation - the idea is to have it aligned with the spec as much as possible to get the ball moving, without getting too much into the weeds. At least that's how I understood it.
This PR also adds support for
trayon the web. After some thought, I realized thattraydoes pretty much the same thing in all environments.Side effect of this was that I had to upload a favicon and I also removed some random HTML jank. Hopefully this does not stray much from the task's core.
Additionally, it adds a mock platform implementation and tests against it. Improves a couple types and adds simple comments explaining what platforms are these methods available on.