Skip to content

syscalls/socket: return 0 for unimplemented SOL_SOCKET options in sys_setsockopt #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rodrigo-Ichaso wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

syscalls/socket: return 0 for unimplemented SOL_SOCKET options in sys_setsockopt #2490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/syscalls/socket/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,13 @@ pub unsafe extern "C" fn sys_setsockopt(
optval: *const c_void,
optlen: socklen_t,
) -> i32 {
if level == SOL_SOCKET && optname == SO_REUSEADDR {
if level == SOL_SOCKET {
// SOL_SOCKET = 4095 cannot be represented as Ipproto (u8), so the
// conversion below would always return EINVAL for any SOL_SOCKET option.
// Return 0 for SO_REUSEADDR (no-op, already the default) and silently
// succeed for other common options (SO_RCVTIMEO, SO_SNDTIMEO, SO_KEEPALIVE,
// SO_LINGER, SO_SNDBUF, SO_RCVBUF) so that Rust std's TCP socket setup
// does not fail during connect/accept.
return 0;
}

Expand Down
Loading