Skip to content

fix(access): remove incorrect check#2483

Merged
mkroening merged 1 commit into
mainfrom
access
Jun 17, 2026
Merged

fix(access): remove incorrect check#2483
mkroening merged 1 commit into
mainfrom
access

Conversation

@mkroening

Copy link
Copy Markdown
Member

Cherry-picked from #2454.

@mkroening mkroening self-assigned this Jun 17, 2026
@mkroening mkroening enabled auto-merge June 17, 2026 10:54
@mkroening mkroening added this pull request to the merge queue Jun 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 35d2d69 Previous: 30cb3f9 Performance Ratio
startup_benchmark Build Time 78.15 s 78.59 s 0.99
startup_benchmark File Size 0.76 MB 0.76 MB 1.01
Startup Time - 1 core 0.73 s (±0.02 s) 0.73 s (±0.02 s) 1.00
Startup Time - 2 cores 0.73 s (±0.02 s) 0.75 s (±0.02 s) 0.98
Startup Time - 4 cores 0.75 s (±0.02 s) 0.76 s (±0.02 s) 0.99
multithreaded_benchmark Build Time 75.09 s 80.39 s 0.93
multithreaded_benchmark File Size 0.82 MB 0.82 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 89.43 % (±6.55 %) 89.59 % (±5.95 %) 1.00
Multithreaded Pi Efficiency - 4 Threads 44.32 % (±2.38 %) 43.86 % (±2.44 %) 1.01
Multithreaded Pi Efficiency - 8 Threads 25.57 % (±1.37 %) 25.65 % (±1.39 %) 1.00
micro_benchmarks Build Time 86.40 s 87.27 s 0.99
micro_benchmarks File Size 0.82 MB 0.82 MB 1.00
Scheduling time - 1 thread 63.92 ticks (±2.72 ticks) 64.58 ticks (±2.95 ticks) 0.99
Scheduling time - 2 threads 34.25 ticks (±2.62 ticks) 35.27 ticks (±2.44 ticks) 0.97
Micro - Time for syscall (getpid) 2.77 ticks (±0.19 ticks) 2.72 ticks (±0.18 ticks) 1.02
Memcpy speed - (built_in) block size 4096 82482.35 MByte/s (±57050.03 MByte/s) 84336.36 MByte/s (±58124.47 MByte/s) 0.98
Memcpy speed - (built_in) block size 1048576 31423.17 MByte/s (±25556.14 MByte/s) 30954.90 MByte/s (±25149.11 MByte/s) 1.02
Memcpy speed - (built_in) block size 16777216 26386.50 MByte/s (±21794.11 MByte/s) 27618.34 MByte/s (±22854.11 MByte/s) 0.96
Memset speed - (built_in) block size 4096 82666.27 MByte/s (±57180.62 MByte/s) 84961.36 MByte/s (±58506.83 MByte/s) 0.97
Memset speed - (built_in) block size 1048576 32104.19 MByte/s (±25917.65 MByte/s) 31697.81 MByte/s (±25573.78 MByte/s) 1.01
Memset speed - (built_in) block size 16777216 27131.49 MByte/s (±22262.54 MByte/s) 28408.60 MByte/s (±23353.48 MByte/s) 0.96
Memcpy speed - (rust) block size 4096 75108.49 MByte/s (±52417.73 MByte/s) 74740.31 MByte/s (±52172.06 MByte/s) 1.00
Memcpy speed - (rust) block size 1048576 31596.13 MByte/s (±25748.31 MByte/s) 30989.85 MByte/s (±25131.37 MByte/s) 1.02
Memcpy speed - (rust) block size 16777216 26165.02 MByte/s (±21609.53 MByte/s) 27766.19 MByte/s (±22932.85 MByte/s) 0.94
Memset speed - (rust) block size 4096 75575.34 MByte/s (±52748.93 MByte/s) 75196.89 MByte/s (±52449.92 MByte/s) 1.01
Memset speed - (rust) block size 1048576 32356.74 MByte/s (±26164.05 MByte/s) 31748.80 MByte/s (±25574.00 MByte/s) 1.02
Memset speed - (rust) block size 16777216 26931.39 MByte/s (±22103.87 MByte/s) 28552.59 MByte/s (±23427.10 MByte/s) 0.94
alloc_benchmarks Build Time 85.24 s 81.63 s 1.04
alloc_benchmarks File Size 0.84 MB 0.84 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 5391.05 Ticks (±83.84 Ticks) 5722.73 Ticks (±63.96 Ticks) 0.94
Allocations - Average Allocation time (no fail) 5391.05 Ticks (±83.84 Ticks) 5722.73 Ticks (±63.96 Ticks) 0.94
Allocations - Average Deallocation time 687.43 Ticks (±118.06 Ticks) 1530.42 Ticks (±212.44 Ticks) 0.45
mutex_benchmark Build Time 85.65 s 80.99 s 1.06
mutex_benchmark File Size 0.82 MB 0.82 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.16 ns (±0.37 ns) 12.10 ns (±0.36 ns) 1.00
Mutex Stress Test Average Time per Iteration - 2 Threads 17.02 ns (±0.58 ns) 17.00 ns (±3.01 ns) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jun 17, 2026
@mkroening mkroening added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit d2179aa Jun 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants