Skip to content

fix(fcntl): return 0 on F_GETFD#2482

Merged
mkroening merged 1 commit into
mainfrom
fcntl-getfd
Jun 17, 2026
Merged

fix(fcntl): return 0 on F_GETFD#2482
mkroening merged 1 commit into
mainfrom
fcntl-getfd

Conversation

@mkroening

Copy link
Copy Markdown
Member

Cherry-picked from #2454.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 726c9b1 Previous: 30cb3f9 Performance Ratio
startup_benchmark Build Time 82.33 s 78.59 s 1.05
startup_benchmark File Size 0.76 MB 0.76 MB 1.00
Startup Time - 1 core 0.76 s (±0.02 s) 0.73 s (±0.02 s) 1.04
Startup Time - 2 cores 0.75 s (±0.02 s) 0.75 s (±0.02 s) 1.00
Startup Time - 4 cores 0.76 s (±0.02 s) 0.76 s (±0.02 s) 1.00
multithreaded_benchmark Build Time 80.60 s 80.39 s 1.00
multithreaded_benchmark File Size 0.82 MB 0.82 MB 1
Multithreaded Pi Efficiency - 2 Threads 91.81 % (±5.49 %) 89.59 % (±5.95 %) 1.02
Multithreaded Pi Efficiency - 4 Threads 44.17 % (±2.68 %) 43.86 % (±2.44 %) 1.01
Multithreaded Pi Efficiency - 8 Threads 25.84 % (±1.48 %) 25.65 % (±1.39 %) 1.01
micro_benchmarks Build Time 94.34 s 87.27 s 1.08
micro_benchmarks File Size 0.82 MB 0.82 MB 1.00
Scheduling time - 1 thread 64.63 ticks (±2.89 ticks) 64.58 ticks (±2.95 ticks) 1.00
Scheduling time - 2 threads 36.14 ticks (±2.82 ticks) 35.27 ticks (±2.44 ticks) 1.02
Micro - Time for syscall (getpid) 2.79 ticks (±0.22 ticks) 2.72 ticks (±0.18 ticks) 1.02
Memcpy speed - (built_in) block size 4096 82935.24 MByte/s (±57182.31 MByte/s) 84336.36 MByte/s (±58124.47 MByte/s) 0.98
Memcpy speed - (built_in) block size 1048576 31396.33 MByte/s (±25603.19 MByte/s) 30954.90 MByte/s (±25149.11 MByte/s) 1.01
Memcpy speed - (built_in) block size 16777216 26224.69 MByte/s (±21823.41 MByte/s) 27618.34 MByte/s (±22854.11 MByte/s) 0.95
Memset speed - (built_in) block size 4096 83001.76 MByte/s (±57232.86 MByte/s) 84961.36 MByte/s (±58506.83 MByte/s) 0.98
Memset speed - (built_in) block size 1048576 32138.88 MByte/s (±26031.00 MByte/s) 31697.81 MByte/s (±25573.78 MByte/s) 1.01
Memset speed - (built_in) block size 16777216 27022.83 MByte/s (±22355.36 MByte/s) 28408.60 MByte/s (±23353.48 MByte/s) 0.95
Memcpy speed - (rust) block size 4096 75235.01 MByte/s (±52595.86 MByte/s) 74740.31 MByte/s (±52172.06 MByte/s) 1.01
Memcpy speed - (rust) block size 1048576 31553.65 MByte/s (±25796.57 MByte/s) 30989.85 MByte/s (±25131.37 MByte/s) 1.02
Memcpy speed - (rust) block size 16777216 25276.42 MByte/s (±20862.16 MByte/s) 27766.19 MByte/s (±22932.85 MByte/s) 0.91
Memset speed - (rust) block size 4096 75467.08 MByte/s (±52750.87 MByte/s) 75196.89 MByte/s (±52449.92 MByte/s) 1.00
Memset speed - (rust) block size 1048576 32340.16 MByte/s (±26250.90 MByte/s) 31748.80 MByte/s (±25574.00 MByte/s) 1.02
Memset speed - (rust) block size 16777216 26079.89 MByte/s (±21424.17 MByte/s) 28552.59 MByte/s (±23427.10 MByte/s) 0.91
alloc_benchmarks Build Time 84.29 s 81.63 s 1.03
alloc_benchmarks File Size 0.84 MB 0.84 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 7080.00 Ticks (±374.52 Ticks) 5722.73 Ticks (±63.96 Ticks) 1.24
Allocations - Average Allocation time (no fail) 7080.00 Ticks (±374.52 Ticks) 5722.73 Ticks (±63.96 Ticks) 1.24
Allocations - Average Deallocation time 703.17 Ticks (±124.45 Ticks) 1530.42 Ticks (±212.44 Ticks) 0.46
mutex_benchmark Build Time 87.35 s 80.99 s 1.08
mutex_benchmark File Size 0.82 MB 0.82 MB 1
Mutex Stress Test Average Time per Iteration - 1 Threads 12.28 ns (±0.45 ns) 12.10 ns (±0.36 ns) 1.01
Mutex Stress Test Average Time per Iteration - 2 Threads 17.24 ns (±1.14 ns) 17.00 ns (±3.01 ns) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening enabled auto-merge June 17, 2026 10:54
@mkroening mkroening added this pull request to the merge queue Jun 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jun 17, 2026
@mkroening mkroening added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit d55ca92 Jun 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants