feat: independently toggle sidebar spaces/agents sections - #3038
feat: independently toggle sidebar spaces/agents sections#3038ahmad9059 wants to merge 1 commit into
Conversation
Adds `visible` to [ui.sidebar.spaces] and [ui.sidebar.agents] (default true, no behavior change). Hiding either section frees its height to the other; hiding spaces also drops the divider line above the agents header while keeping the "agents" label and sort toggle visible. Hiding both collapses the sidebar to zero width, matching sidebar_collapsed_mode = "hidden".
|
Hi @ahmad9059, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The sidebar's "spaces" and "agents" sections are always shown together today. This adds a
visibleflag to each so they can be toggled independently, with the other section expanding to fill the freed height.spacesdrops its header, workspace list, and "new"/"menu" footer; the agents section's divider line above the "agents" label is also removed, but the label and sort ("grouped") toggle still render — only the divider goes away.agentsdrops that section entirely and spaces expands to fill the height.sidebar_collapsed_mode = "hidden". This is separate from the manualprefix+bcollapse toggle, which still works independently.truefor both, so existing configs are unaffected.Test plan
compute_viewandconfig::test filters also green (3 and 149 passed) around the layout/config edits.cargo build --release --lockedsucceeds;--version,--help, and--default-config(both newvisibleblocks documented) verified manually.Screenshots to follow.