Skip to content

feat: independently toggle sidebar spaces/agents sections - #3038

Closed
ahmad9059 wants to merge 1 commit into
herdrdev:masterfrom
ahmad9059:feat/sidebar-section-visibility
Closed

feat: independently toggle sidebar spaces/agents sections#3038
ahmad9059 wants to merge 1 commit into
herdrdev:masterfrom
ahmad9059:feat/sidebar-section-visibility

Conversation

@ahmad9059

Copy link
Copy Markdown

Summary

The sidebar's "spaces" and "agents" sections are always shown together today. This adds a visible flag to each so they can be toggled independently, with the other section expanding to fill the freed height.

[ui.sidebar.spaces]
visible = false   # default: true

[ui.sidebar.agents]
visible = false   # default: true
  • Hiding spaces drops its header, workspace list, and "new"/"menu" footer; the agents section's divider line above the "agents" label is also removed, but the label and sort ("grouped") toggle still render — only the divider goes away.
  • Hiding agents drops that section entirely and spaces expands to fill the height.
  • Hiding both collapses the sidebar to zero width, matching sidebar_collapsed_mode = "hidden". This is separate from the manual prefix+b collapse toggle, which still works independently.
  • Default is true for both, so existing configs are unaffected.

Test plan

  • Focused sidebar test suite: 140 passed, 0 failed, including new regression coverage for:
    • divider hidden but agents header/toggle still rendering with spaces hidden
    • header still rendering (nonzero panel size) with zero agents and spaces hidden
    • height split when either section is hidden
    • sidebar collapsing to zero width when both are hidden
  • compute_view and config:: test filters also green (3 and 149 passed) around the layout/config edits.
  • cargo build --release --locked succeeds; --version, --help, and --default-config (both new visible blocks documented) verified manually.

Screenshots to follow.

image

Adds `visible` to [ui.sidebar.spaces] and [ui.sidebar.agents] (default
true, no behavior change). Hiding either section frees its height to
the other; hiding spaces also drops the divider line above the agents
header while keeping the "agents" label and sort toggle visible.
Hiding both collapses the sidebar to zero width, matching
sidebar_collapsed_mode = "hidden".
@kangal-bot

Copy link
Copy Markdown
Collaborator

Hi @ahmad9059, thanks for your interest in contributing.

Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in .github/APPROVED_CONTRIBUTORS.

The pull request author is not an approved contributor.

If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents.

Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written.

If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically.

See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy.

@kangal-bot kangal-bot closed this Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 09f6e735-f5dc-44dc-b6f0-49bcc974c980

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants