Repository navigation
Fix low findings from the Fable review of the 337c5858c3 sync - #308
Merged
Merged
Conversation
- Cut the client half of upstream's socket frame parts (pingdotgg#23758) and shared socketFrameParts.ts: the split lives on upstream's uncarried /ws upgrade and the gateway forwards whole helper stdio frames. - Drop the unused KiroIcon. - Seed the server-config provider stream and the synthesized lifecycle stream with rpcInitialItems, as upstream does, so delivered snapshots are released. - mapSessionRpcError maps settings errors to upstream's remote-unavailable reason. - Carry upstream's subscription-defect resubscribe test (pingdotgg#31071). - Seams doc: useOpenLink.ts entry, frame-parts and KiroIcon cuts; sync.md lists useOpenLink.ts as kept in web browser/. - Port upstream's rich-text marker editing paragraph to composer.md. - The fork-only worktree rename refusal says T3 Coder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #307. Two Fable 5.1 reviewers (server/packages; web/client-runtime/docs) found no high or medium issues and no merge losses. This fixes the confirmed low findings.
Fixed
shared/socketFrameParts.ts. The split lives on upstream's/wsupgrade, which the helper never serves; the gateway forwards whole helper stdio frames, so the joiner was inert (no dormant code). Recorded in the seams doc andsync-resolve-deleted.mjs.KiroIcon(Kiro is cut).ws.tsseeds the server-config provider stream and the synthesized lifecycle stream withrpcInitialItems, as upstream does, so delivered snapshots are not retained for the life of each subscription.mapSessionRpcErrormapsKeybindingsConfigParseError/ServerSettingsErrorto upstream'sremote-unavailablereason.client.test.ts.browser/useOpenLink.ts;sync.mdlists it as the kept file of webbrowser/.docs/user/composer.mdgains upstream's rich-text marker editing paragraph (fix(web): make styled composer Markdown markers editable pingdotgg/t3code#30421).Dismissed
cloudOnly/hasCloudPublicConfigin settings search: the fork passes fixed availability flags into upstream's filter; removing the clause would add drift tosettingsSearch.ts.hop/viaon session errors: the fork's connection model does not carry those fields.Verification: fmt check, typecheck server/web/client-runtime/shared/ACP packages, knip:check, seams-check,
test:client-runtime(1102 passed),test:shared:coder, server ws/server tests, web settings unit tests,pnpm build.🤖 Generated with Claude Code