Skip to content

Command palette: typing !N does not find a thread by its merge request #306

Open

Description

@henrychu04

Found in the Fable review of the 47f2c8d sync (#304); predates that sync.

The command palette shows a thread's merge request match as MR !42 (fork seam in matchHint, packages/shared/src/paletteSearch.ts), but the search fields index merge requests as #42 (threadSearchFields) and threadFieldQuery strips only pr / pull request / # prefixes. Typing !42 finds nothing; 42 and #42 work.

The seams doc keeps search haystacks in upstream's spelling, so a fix would be a small marked seam in threadFieldQuery (also strip a leading ! and mr), listed in docs/internals/coder-only.md. Low severity: the workaround is to type the number alone.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions