Skip to content

typecheck:server fails on GitVcsDriverCore.test.ts after the eb1510d249 sync #246

Closed

Description

@henrychu04

pnpm typecheck:server on coder-only (28e1392) fails with two errors in apps/server/src/vcs/GitVcsDriverCore.test.ts (lines 127 and 138): the fixture's exitCode: number is not assignable to the branded ExitCode in ExecuteGitResult. The test file came in with the eb1510d sync (PR #241); the tests themselves run.

Check whether upstream's file brands the value (ExitCode.make(...)) and the sync lost it, or whether the fork's ExecuteGitResult diverged.

Activity

  1. henrychu04 commented on Oct 28, 2026

    @henrychu04
    OwnerAuthor

    No longer reproduces on coder-only 116e4a2: pnpm typecheck:server reports no errors in GitVcsDriverCore.test.ts, and the file's 163 tests pass. The fixture typing changed in the 7df7cb9/becf853def syncs (90ee70b, 8b4cc0d).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions