Repository navigation
Conversation
The library's pictures were grey, so the list did not say what colour a shape would land in. Each entry now wears the colour a new shape of its kind starts with: the catalogue's own, or the colour saved in the shape defaults. The grey render keeps its shading. A colour layer masked by the picture outlines multiplies over it, in the list, in the icon-only size and in both themes. shapeAssetColor() is the single rule, shared with makeShapeFromAsset(), and tested in shapeCatalog.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shape library's pictures were grey, so the list said nothing about the colour a shape would land in. Every library entry now wears the colour a new shape of its kind starts with: the catalogue's own, or the colour saved for that kind under Shape defaults.
The grey render keeps its shading: a colour layer, masked by the picture's outline, multiplies over it.
shapeAssetColor()inshapeCatalog.tsis the single rule and is shared withmakeShapeFromAsset(), so the picture cannot drift from the body that is added.shapeCatalog.test.ts; the graphite theme stylesheet was regenerated.Validation:
npm test: 2806/2806npm run typechecknpm run export: static export succeeds