[create] Round out Seam C --help smoke coverage (#2959) - #30
Merged
Conversation
Verified item 1: running `npm test` against the registry-resolved @haxtheweb/haxcms-nodejs@26.8.1 (satisfies ^26.8.0) now passes 143/0/0 (pass/skip/fail), up from 137 pass with the previously gated tests skipped. No test-code changes were needed for this part — canary gating auto-activated as expected. Item 2: added --help smoke tests for the remaining subcommands (party, audit, skills, update, serve, start) to round out the subcommand help set, per the issue's suggested additions. The `hax site create` and `hax webcomponent` non-interactive smoke tests already existed in this file. Co-Authored-By: Warp <agent@warp.dev>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to additional smoke tests and do not alter runtime CLI behavior, with only minor maintainability feedback noted.
Pull request overview
This PR expands the CLI “Seam C” subprocess smoke test coverage by adding --help smoke checks for additional Tier 3 subcommands, supporting the goal of ensuring the public CLI surface is exercised in CI (as described in #2959).
Changes:
- Add smoke tests asserting
create <subcommand> --helpexits 0 for:party,audit,skills,update,serve,start. - Keep the existing subprocess-based approach (spawn the built
dist/create.jsin an isolated HOME) consistent with the rest of the smoke suite.
File summaries
| File | Description |
|---|---|
| test/smoke/cli.smoke.test.cjs | Adds --help subprocess smoke tests for more CLI subcommands to round out Seam C coverage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes both work items from haxtheweb/issues#2959.
1. Verify the 46 CI skips auto-activate to passes
@haxtheweb/haxcms-nodejs@26.8.1is now published and satisfies the existing^26.8.0dependency range, shipping the previously-missingdist/lib/{HAXCMS,allRoutes,safeFetch,sanitizeContent}.jsfiles.Ran
npm testagainst the registry-resolved package (nonpm link):No test-code changes were needed — the canary gating in
test/_helpers/module-canary.cjsauto-activated as designed.2. Wire in Tier 3 subprocess coverage (Seam C expansion)
The two specific suggested additions (
hax site create --y ...andhax webcomponent ... --y) already existed intest/smoke/cli.smoke.test.cjs. This PR rounds out the remaining subcommand help set mentioned in the issue by adding--helpsmoke tests for:party,audit,skills,update,serve,start.Test plan
npm run build && npm test→ 143 tests, 0 fail, 0 skip.Co-Authored-By: Warp agent@warp.dev