🐛 Fix terminal rendering issues on iOS Safari via DOM renderer#1035
🐛 Fix terminal rendering issues on iOS Safari via DOM renderer#1035owine wants to merge 1 commit intohassio-addons:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdded a ttyd startup option to force xterm.js to use DOM rendering by appending Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Switch ttyd's xterm.js renderer from the default WebGL/Canvas to the DOM renderer using --client-option rendererType=dom. WebGL rendering on iOS Safari is unreliable — it silently falls back or produces garbled/invisible output. The DOM renderer trades a small amount of rendering performance for broad browser compatibility. Fixes hassio-addons#1016, hassio-addons#1026, hassio-addons#1027
147859f to
929555a
Compare
What
Add
--client-option rendererType=domto the ttyd options in the run script.Why
xterm.js defaults to WebGL → Canvas → DOM renderer order. On iOS Safari, the WebGL and Canvas renderers produce garbled, unreadable terminal output. Pinning to the DOM renderer fixes this.
This is a separate issue from the theme color change in #1033/#1034. That PR addressed unreadable text contrast; this addresses the renderer producing garbled output on iOS.
Closes #1016
Closes #1026
Closes #1027
Summary by CodeRabbit