Skip to content

Remove deprecated codenotary fields#257

Merged
frenck merged 1 commit intomainfrom
frenck-2025-0494
Nov 15, 2025
Merged

Remove deprecated codenotary fields#257
frenck merged 1 commit intomainfrom
frenck-2025-0494

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Nov 15, 2025

Proposed Changes

SSIA

Summary by CodeRabbit

  • Chores
    • Removed codenotary external signing configuration and associated metadata fields from build and configuration files.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 15, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 15, 2025

Walkthrough

Removed codenotary configuration from two phpmyadmin YAML files: eliminated the codenotary block containing base_image and signer keys from build.yaml, and removed the codenotary email metadata field from config.yaml. No other configurations affected.

Changes

Cohort / File(s) Summary
Codenotary configuration removal
phpmyadmin/build.yaml, phpmyadmin/config.yaml
Removed codenotary external signing block (base_image, signer) from build.yaml and codenotary metadata field from config.yaml

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple removal of configuration fields with no logic changes or side effects
  • Both changes are consistent in nature (eliminating codenotary integration)

Poem

A rabbit hops through configs clean,
Removing signers not yet seen,
Codenotary wings now spread and fly,
We simplify—no questions why! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove deprecated codenotary fields' directly and accurately describes the main changes in the pull request, which involve removing codenotary configuration blocks and fields from phpmyadmin/build.yaml and phpmyadmin/config.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0494

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56b8053 and b460b24.

📒 Files selected for processing (2)
  • phpmyadmin/build.yaml (0 hunks)
  • phpmyadmin/config.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • phpmyadmin/build.yaml
  • phpmyadmin/config.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit 161018c into main Nov 15, 2025
22 checks passed
@frenck frenck deleted the frenck-2025-0494 branch November 15, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant