Pull along Tailwind configuration, generating CSS again#617
Open
dschrempf wants to merge 14 commits into
Open
Conversation
Config moves from tailwind.config.js (deleted) into assets/css/tailwind.css (@theme/@source/@plugin); postcss.config.js uses @tailwindcss/postcss and drops postcss-import. Regenerate the dev.css snapshot. Address PR haskellfoundation#281 review: the README now documents when Node is needed vs. the Node-free dev.css preview, gives Stack and Cabal equal billing (and fixes the broken 'cabal run -- site build' invocation), and updates the stale CI step list. Drop the disparaging site.hs comment and fix the hakyll typos, wrong paths, and ambiguous wording in the tailwind.css header.
The heading rule asked for 700, but the Google Fonts link only loads Playfair Display 400/600/800, so headings snapped to 800 (extra-bold). Regular reads better across the site. With headings now 400, the font-w-800 utility (only on the homepage hero) was dead, so remove its @theme token and the class.
Collaborator
Author
|
Pulling @LaurentRDC @jaspervdj in. |
LaurentRDC
reviewed
Jul 9, 2026
Comment on lines
+65
to
+69
| ```bash | ||
| npm ci # once, to install the toolchain | ||
| npm run build # compile -> _site/assets/css/tailwind.css | ||
| npm run build:production # minified build (NODE_ENV=production) | ||
| ``` |
Contributor
There was a problem hiding this comment.
There's a nix flake in this repo -- can we list the steps to use that flake if one doesn't want to install npm globally?
jaspervdj
reviewed
Jul 9, 2026
| config :: Configuration | ||
| config = defaultConfiguration | ||
| { ignoreFile = \file -> | ||
| "node_modules" `isPrefixOf` file || |
Collaborator
There was a problem hiding this comment.
I moved this here in e769aa5, rather than having the ignore on individual matches.
Collaborator
Author
There was a problem hiding this comment.
Thanks, I will apply the commit. I guess this will also have consequences on "isolating node_modules", which is still an open task.
Collaborator
Author
There was a problem hiding this comment.
Oh, I saw that you already applied it yourself!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Late-stage draft (there are a few things to do, see below).
This supersedes #281.
This PR (#281) reintroduces a working, checked-in Tailwind/PostCSS build for assets/css/main.css after it had bitrotted, and wires it into both local dev and CI:
The website content remains unchanged.
Review concerns of #281 already addressed at this stage of the PR:
hackylltypos + wrong paths + ambiguous "this file" wording (tailwind.cssheader)Review concerns not yet addressed:
cat-based concat breaks Windows (site.hs:41)node_modulesinto its own dirdev.cssReview concerns that are not valid anymore due to upgrade to Tailwind 4
tailwind.config.js"3"→"3px"nitNote: Some of this work was done by an LLM; I have reviewed all changes and tested the local site builds, but I am declaring this here, since there are ongoing discussions about the use of LLMs in the Haskell community.