Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
… frontmatter
PrefixLines unconditionally prepended the indent prefix to every line,
including empty strings produced by splitting on blank lines. In YAML
block scalars this created lines containing only spaces (" ") rather
than genuinely empty lines.
Skip adding the prefix when the line is empty, so blank lines inside a
provider description pass through unchanged.
javabrett
force-pushed
the
fix/prefixlines-blank-line-whitespace
branch
from
June 2, 2026 00:18
17c2b03 to
cdf644a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a provider resource's
Description(orMarkdownDescription) contains blank lines — for example, surrounding a code fence — the generated YAML frontmatter ends up with whitespace-only lines (, two spaces) instead of genuinely blank lines.Root cause
PrefixLinesininternal/tmplfuncs/tmplfuncs.gowas implemented as:strings.Splitproduces an empty string""for each blank line.strings.Jointhen inserts"\n" + prefixbefore that empty string, yielding a line that is just the prefix (e.g." ") with no content.The
prefixlines " "template filter is used in the YAML frontmatter block scalar in all four default templates (resource, data source, function, action):So any blank line in a provider description becomes a whitespace-only line in the generated
docs/output.Fix
Skip adding the prefix when the line is empty:
Tests
Added
internal/tmplfuncs/tmplfuncs_test.gowith unit tests forPrefixLines, including the blank-line regression case. The failing test case with the old implementation:"line1\n\nline3", prefix" "" line1\n \n line3"(middle line is" ", two spaces)" line1\n\n line3"(middle line is empty)The existing
TestRenderStringTemplateininternal/provider/template_test.gocontinues to pass unchanged.