Skip to content

fix: use max int for gRPC message limits - #411

Draft
dannyward630 wants to merge 1 commit into
hashicorp:mainfrom
dannyward630:fix/issue-184-max-grpc-message-size
Draft

dannyward630 wants to merge 1 commit into
hashicorp:mainfrom
dannyward630:fix/issue-184-max-grpc-message-size

Conversation

@dannyward630

Copy link
Copy Markdown

Description

Use math.MaxInt for the default gRPC send and receive message-size options. The current math.MaxInt32 limit blocks messages above 2 GiB on 64-bit hosts. Add a regression test that checks the limit follows the platform's maximum int.

Related Issue

Fixes #184.

How Has This Been Tested?

  • go test . -run '^TestGRPCMaxMessageSize$' -count=1 with Go 1.27.2 on Windows/amd64: passed.
  • go vet ./... with Go 1.26.9 on Windows/amd64: passed.
  • go test ./... was attempted with Go 1.26.9 and 1.27.2 on Windows; both runs failed at TestServerLogPanic (client_test.go:1608). The logs also report TerminateProcess: Access is denied from helper plugin processes.

Contributor Checklist

  • LLM Usage I used Codex to help prepare the change, read and followed the AI usage guide, reviewed the diff, and understand the submitted code.

@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dialGRPCConn should default recv/send msg size to max int not max int32

1 participant