Skip to content

grpc_client: check SERVING status in Ping #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alliasgher wants to merge 3 commits into
base: main
Choose a base branch
from
Open

grpc_client: check SERVING status in Ping #377

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd79efb
grpc_client: check SERVING status in Ping
alliasgher Apr 14, 2026
da445f6
grpc_stdio, plugin_test: migrate from deprecated github.com/golang/pr…
alliasgher Apr 14, 2026
b4bb669
Merge remote-tracking branch 'upstream/main' into fix-grpc-ping-check…
alliasgher Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,16 @@ func (c *GRPCClient) Dispense(name string) (interface{}, error) {
// ClientProtocol impl.
func (c *GRPCClient) Ping() error {
client := grpc_health_v1.NewHealthClient(c.Conn)
_, err := client.Check(context.Background(), &grpc_health_v1.HealthCheckRequest{
resp, err := client.Check(context.Background(), &grpc_health_v1.HealthCheckRequest{
Service: GRPCServiceName,
})
if err != nil {
return err
}

if resp.Status != grpc_health_v1.HealthCheckResponse_SERVING {
return fmt.Errorf("plugin %q health check returned non-SERVING status: %s", GRPCServiceName, resp.Status)

@tgross tgross Sep 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't GRPCServiceName just the const "plugin"? This looks like we've grabbed that without knowing where it came from.

}

return err
return nil
}