Restrukture Code, Improve Dokumentation and Indroduce Unit Testing (#10) - #11
Merged
Conversation
* rename all names to DS3231-RTC * header include guard needs underscores * Update README.md - added getYearDay() * rework docu to time getting functions * update Tests and class structure * Update GitHub Actions workflow for compiling examples * Downgrade arduino/compile-sketches action to v1 * Add C++17 compiler flags to compile workflow Add extra compiler flags for C++17 support in Arduino workflow. * remove Unix_offset and NTP_offset from Constants * remove std::optional * update examples to reowked code * reorder includes * rework clock mode setter * Bugfix for RTC::now in hour calculation, add begin() method; add method to get hour mode * adapt examples with begin() method * update keyword.txt * Remove build folder from version control * add tests to readme; comment bin2dec function * remove double defined function bcd2bin; replace functional code by more performant bcd functiontional code. * restructure static funtions => make them constexpr * Update unit tests; update libraries informations; adapt Readme * adapt work flow rund for unit tests * add status badge for Readme * Delete .DS_Store * update Readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename all names to DS3231-RTC
header include guard needs underscores
Update README.md
rework docu to time getting functions
update Tests and class structure
Update GitHub Actions workflow for compiling examples
Downgrade arduino/compile-sketches action to v1
Add C++17 compiler flags to compile workflow
Add extra compiler flags for C++17 support in Arduino workflow.
remove Unix_offset and NTP_offset from Constants
remove std::optional
update examples to reowked code
reorder includes
rework clock mode setter
Bugfix for RTC::now in hour calculation, add begin() method; add method to get hour mode
adapt examples with begin() method
update keyword.txt
Remove build folder from version control
add tests to readme; comment bin2dec function
remove double defined function bcd2bin; replace functional code by more performant bcd functiontional code.
restructure static funtions => make them constexpr
Update unit tests; update libraries informations; adapt Readme
adapt work flow rund for unit tests
add status badge for Readme