Repository navigation
fix: restore compilation of scoregate-score - #157
Merged
Merged
Conversation
main does not compile: `cargo test -p scoregate-score --lib` fails with 10 errors, so the whole test suite is unrunnable. - verkle.rs was truncated to 210 lines, ending mid-statement at `let mut buf =`, with a literal truncation marker. Restored from 42958bb. - The ledgerlens-score -> scoregate-score rename dropped four storage functions that governance_helpers.rs still calls. Restored from 2d161b7, plus the two DataKeyD variants they need. - finalize_score_state was lost the same way. Restored from 0f5f35a. - query_risk_gate_with_confidence called env.invoker(), which is not a Soroban API. The working version used env.current_contract_address(). - events.rs was missing the Vec import; storage.rs needed a type annotation and no longer uses SymbolStr. 772 tests pass, 20 fail. Those 20 are pre-existing and unrelated to this change (ttl_rent_manager, migration_rollback, malformed_proof_corpus and others); they are left for the issues that own them.
|
Hey @ayomidearegbeshola29-dev! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main does not compile, so the test suite cannot run at all. This restores the build.
What was broken
cargo test -p scoregate-score --libfails with 10 errors on main:verkle.rswas truncated to 210 lines, ending mid-statement atlet mut buf =, with a literal truncation marker. Restored byte-identical from42958bb.ledgerlens-score->scoregate-scorepackage rename (c54f61b) dropped four storage functions thatgovernance_helpers.rsstill calls. Restored from2d161b7, plus the twoDataKeyDvariants they need.finalize_score_statewas lost the same way. Restored from0f5f35a.query_risk_gate_with_confidencecalledenv.invoker(), which is not a Soroban API. The working version usedenv.current_contract_address().events.rswas missing theVecimport;storage.rsneeded a type annotation and no longer usesSymbolStr.I confirmed each of these by checking that upstream main still fails after only the verkle restore, so the verkle fix alone is not enough.
Verification
cargo check -p scoregate-score --lib— cleancargo test -p scoregate-score --lib— 772 pass, 20 failThe 20 failures are pre-existing and in unrelated modules (ttl_rent_manager, migration_rollback, malformed_proof_corpus, reconciliation, rejection_precedence, and others). They are left for whichever issues own them; this PR only restores the build so they can be investigated and so the feature issues can be worked on.
Note
cargo testrewrites ~350 files undertest_snapshots/. Those are test artifacts, not part of this change, and were reverted before committing — the diff is 5 source files only.