Repository navigation
Review CSV rows without contact identity columns - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Company, deal, and other CSV exports must remain reviewable without an email or name column. The generic browser workspace already accepts them, but previously produced no review findings when email checks were unavailable.
Add empty-row and exact whole-row repetition findings independently of email mapping, and append optional email warnings. Preserve every source cell and include unresolved rows unless explicitly excluded. Explain the scope of active checks and document refreshing the older uploader. Keep the separate connected contact import contract intact.
Validation: 24 focused unit tests, TypeScript, focused ESLint, script syntax, public production build, and diff checks passed. Desktop/mobile browser checks exercised company/deal files without identity columns, exact downloads, findings, edits, exclusion/restore, Undo, and the legacy audit URL. No processing HTTP calls or persistent browser storage occurred. A fictional no-identity company file also opened on the current live site; the added review findings have not been deployed there.